-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NLP] Support the different mask tokens used by NLP models for Fill Mask #97453
Conversation
...ore/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/FillMaskConfig.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/BertTokenization.java
Show resolved
Hide resolved
ca8e243
to
662358e
Compare
Pinging @elastic/ml-core (Team:ML) |
Hi @maxhniebergall, I've created a changelog YAML for you. |
...rc/test/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/FillMaskConfigTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This largely looks good now.
One more thing that needs changing is the current reference docs. We need a new entry for mask_token
immediately before this line:
`tokenization`:::: |
...ore/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/FillMaskConfig.java
Outdated
Show resolved
Hide resolved
Hi @maxhniebergall, I've updated the changelog YAML for you. |
66e94ce
to
f7f19ae
Compare
f7f19ae
to
b1ec57b
Compare
docs/reference/ml/trained-models/apis/get-trained-models.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/ml/trained-models/apis/get-trained-models.asciidoc
Outdated
Show resolved
Hide resolved
...rc/test/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/FillMaskConfigTests.java
Outdated
Show resolved
Hide resolved
@elasticsearchmachine run elasticsearch-ci/rest-compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ask (#2178) Adds the specification for the new mask token field added in elastic/elasticsearch#97453, which enables users and Kibana to see the mask token for a particular model
This change adds a
mask_token
field to theGET _ml/trained_models
API, as an enhancement to support kibana#159577.The
mask_token
field reveals the particular mask token for needed each model deployed. Below is an exampleinference_config
component of the API response, with the newmask_token
field withinfill_mask
.